Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the runtime dependency #23

Open
diegofrata opened this issue Aug 24, 2022 · 3 comments
Open

Remove the runtime dependency #23

diegofrata opened this issue Aug 24, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@diegofrata
Copy link
Owner

Another idea is to remove the runtime dependency, especially for those who don't use custom Comparers. They can be delivered explicitly (with global:: full typepaths to avoid possible collisions).

Originally posted by @HavenDV in #22 (comment)

@diegofrata
Copy link
Owner Author

diegofrata commented Aug 24, 2022

I don't see much gain in removing the runtime dependency only for cases without custom comparers, to me this is either all or nothing -- either we move all comparers to be source generated and get rid of the runtime dependency at all or we don't. It's a sizeable piece of work.

@diegofrata diegofrata assigned diegofrata and unassigned diegofrata Aug 24, 2022
@diegofrata diegofrata added the enhancement New feature or request label Aug 24, 2022
@HavenDV
Copy link
Contributor

HavenDV commented Aug 25, 2022

The main problem is that the Runtime package has a dependency:

<PackageReference Include="Microsoft.Bcl.HashCode" Version="1.1.0" />

@diegofrata diegofrata added this to the 3.0 milestone Dec 31, 2022
@diegofrata diegofrata removed this from the 3.0 milestone Apr 23, 2023
@diegofrata
Copy link
Owner Author

This has been removed from 3.0 as it caused issues in packages with InternalsVisibleTo. Needs to rethink the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants