Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use with preact #102

Open
ColCh opened this issue Feb 18, 2020 · 2 comments
Open

Use with preact #102

ColCh opened this issue Feb 18, 2020 · 2 comments
Labels
help wanted Extra attention is needed pr welcome

Comments

@ColCh
Copy link

ColCh commented Feb 18, 2020 •
edited

this package exports React.FunctionComponent type, but preact has different type

I found no issues running this package with preact (without actually running :) ), but it's nearly impossible to do with TypeScript due to typings

image
@diegohaz diegohaz added help wanted Extra attention is needed pr welcome labels Feb 18, 2020
@diegohaz
Copy link
Owner

Hi @ColCh! I’m not familiar enough with preact to think on a fix for that. Do you have any idea? 🙂

@ColCh
Copy link
Author

ColCh commented Feb 19, 2020

Me to ...

Seems like this is some good advice posted here preactjs/preact-compat#497

TLDR: move react and preact to peerDeps, add preact separate entrypoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed pr welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ColCh @diegohaz