Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail a PR if it changes source code without a changelog entry #15

Open
nedtwigg opened this issue Oct 5, 2020 · 0 comments
Open

Fail a PR if it changes source code without a changelog entry #15

nedtwigg opened this issue Oct 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@nedtwigg
Copy link
Member

nedtwigg commented Oct 5, 2020

Spotless Changelog can handle the case where a single git repository has multiple changelogs for its various components. However, it can be easy to miss when a changelog which is mostly about component A, actually also brushes againt component B, and it can be bad if you forget to add a changelog for component B.

Perhaps we should implement something like the following:

spotlessChangelog {
  ifAnyFilesChangedIn('./lib/**/*', './lib-extra/**/*').since('origin/main').thenEntryRequired()
  ...

The snippet above could have avoided a problem we had recently in spotless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant