Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate current usage of Electron IPC and Node in renderer and update to follow better practices #731

Open
ximenabb opened this issue Jun 28, 2023 · 0 comments
Assignees
Labels

Comments

@ximenabb
Copy link

ximenabb commented Jun 28, 2023

Description

The goal of this work is to disable Node integration and enable context isolation in the app renderer window, as well as improve the readability for maintenance purposes.

There are various items to addresss:

  1. Electron renderer IPC usage is scattered all over the place and would be better to consolidate into the preload, as recommended.

  2. Our usage of @electron/remote is discouraged by the project and should be removed so that features relying on this are using the recommended IPC mechanisms.

  3. Our usage of Node APIs is scattered and if possible, we should consolidate it in either the preload (which has access to some Node APIs) or at least in a dedicated file/directory to make it easier to migrate if necessary.

@achou11 achou11 changed the title Move map server, mapeo core to utilityprocess Evaluate current usage of Electron IPC and Node in renderer and update to follow better practices Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Todo
Development

No branches or pull requests

2 participants