Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mapbox token v1 #756

Closed
3 tasks done
ximenabb opened this issue Apr 22, 2024 · 1 comment
Closed
3 tasks done

Update Mapbox token v1 #756

ximenabb opened this issue Apr 22, 2024 · 1 comment
Assignees
Labels

Comments

@ximenabb
Copy link

ximenabb commented Apr 22, 2024

Description

Full bug here : #755
Since the proper fix can require quite of few days of work, and since this fix is urgent, here is a proposed patch release:

Todo

Once the above items are done, can publish a patch release that branches off from the most recent patch release branch (we don't want to include recent commits on master branch that have not been tested/QA'd)

User impact

Due to time constraints, this release will not be code-signed/notarized. Users should expect the following in order to run the app after installing:

  • on Windows: They will get a warning of potential malicious software

  • On Mac: They will need to right+click press and Open, instead of just clicking the icon to open

  • Mapeo Desktop will not auto-update, it will require a manual update to get this fix

@achou11
Copy link
Member

achou11 commented May 14, 2024

Closing as this has now been addressed by the changes found on this branch:

https://github.com/digidem/mapeo-desktop/tree/v5.6.3/fix-mapbox-token

v5.6.3 tag was pushed to this branch to create the release

publishAutoUpdate: false seems to have worked as well (no latest.yml file uploaded to S3)

@achou11 achou11 closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants