Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade nodejs-mobile-react-native to v16.17.10 #1100

Open
sethvincent opened this issue May 29, 2023 · 2 comments · May be fixed by #1104
Open

upgrade nodejs-mobile-react-native to v16.17.10 #1100

sethvincent opened this issue May 29, 2023 · 2 comments · May be fixed by #1104
Assignees

Comments

@sethvincent
Copy link
Contributor

https://github.com/nodejs-mobile/nodejs-mobile-react-native

@ErikSin
Copy link
Contributor

ErikSin commented Jun 8, 2023

Moving to Sprint 8: Needs about a weeks worth for completion

@achou11 achou11 linked a pull request Jun 15, 2023 that will close this issue
@achou11
Copy link
Member

achou11 commented Jun 15, 2023

update on this: decided to hold off actually merging this into development because of concerns around how the backend runs on Node 16. Most of the essential work is done in #1104 but with some uncertainties that have popped up in the backend tests. Instead of trying to update the backend to adapt to this version and potentially introduce more instability, it would make more sense to use the work from that PR as the basis for the work to integrate mapeo core next when the time comes.

The proposed action is to keep that PR open as a living branch so that it can be used for mapeo core next work. the actual upgrade works fine on the device, it's just the concerns around unknowns that make us hesitant until mapeo core next can be introduced

@gmaclennan feel free to add any additional details to this based on our conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants