Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE9 compatibility #53

Open
oliviertassinari opened this issue Sep 28, 2016 · 5 comments
Open

IE9 compatibility #53

oliviertassinari opened this issue Sep 28, 2016 · 5 comments
Milestone

Comments

@oliviertassinari
Copy link

oliviertassinari commented Sep 28, 2016

This module is using the console API: https://github.com/digidem/react-dimensions/blob/master/index.jsx#L162.
Notice that this API isn't available in IE9. Besides, I don't think that throwing a warning in production has much value.

We could be using https://www.npmjs.com/package/warning with https://www.npmjs.com/package/babel-plugin-transform-dev-warning to remove those check in production.

@gmaclennan gmaclennan added this to the 2.0.0 milestone Sep 28, 2016
@gmaclennan
Copy link
Member

Did now know that about IE9. Agreed.

@elyobo
Copy link

elyobo commented Oct 4, 2016

The console.warnings are also annoying when this is being rendered server side; it's generating noise in the logs for expected behaviour (height and width are not expected to be present on the server).

@sontek
Copy link

sontek commented Mar 29, 2017

@gmaclennan Whats the status of this? Warnings definitely shouldn't be ran in NODE_ENV=production

@oliviertassinari
Copy link
Author

@sontek Here is my workaround if that can help.

@gmaclennan
Copy link
Member

Happy to accept a PR, I'm not really using this any more since for grids/tables in React I've switched from fixed-data-table (which I was using this for) to react-virtualized which includes similar functionality to this with the Autosizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants