From ba58475726951194cc9e737f32347f3c515bc8cd Mon Sep 17 00:00:00 2001 From: Andreas Herrmann Date: Thu, 17 Mar 2022 15:03:06 +0100 Subject: [PATCH] Disable create-daml-app tests on MacOS M1 These fail to build because puppeteer fails to install Chromium on M1. See https://github.com/digital-asset/daml/pull/13250. --- daml-assistant/integration-tests/BUILD.bazel | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/daml-assistant/integration-tests/BUILD.bazel b/daml-assistant/integration-tests/BUILD.bazel index 6d11b215b82e..59f77cdd7efa 100644 --- a/daml-assistant/integration-tests/BUILD.bazel +++ b/daml-assistant/integration-tests/BUILD.bazel @@ -1,7 +1,7 @@ # Copyright (c) 2022 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. # SPDX-License-Identifier: Apache-2.0 load("//bazel_tools:haskell.bzl", "da_haskell_library", "da_haskell_test") -load("@os_info//:os_info.bzl", "is_windows") +load("@os_info//:os_info.bzl", "is_darwin_arm64", "is_windows") load("@build_environment//:configuration.bzl", "mvn_version") genrule( @@ -199,7 +199,9 @@ genrule( "@nodejs//:node_bin", "@nodejs//:npm_bin", ], -) if not is_windows else None + # Broken on M1 due to puppeteer failing to install Chromium. + # See https://github.com/digital-asset/daml/pull/13250. +) if not (is_darwin_arm64 or is_windows) else None da_haskell_library( name = "create-daml-app-tests-lib", @@ -234,7 +236,7 @@ da_haskell_library( "//libs-haskell/da-hs-base", "//libs-haskell/test-utils", ], -) if not is_windows else None +) if not (is_darwin_arm64 or is_windows) else None da_haskell_test( name = "create-daml-app-tests-proj-name", @@ -255,7 +257,8 @@ da_haskell_test( flaky = True, # npm/jest/puppeteer can be flaky hackage_deps = ["base"], main_function = "DA.Daml.Assistant.CreateDamlAppTestsMain.main", - # Exclusive until we stop hardcoding port numbers in index.test.ts - tags = ["exclusive"], + tags = + # Exclusive until we stop hardcoding port numbers in index.test.ts + ["exclusive"], deps = [":create-daml-app-tests-lib"], -) if not is_windows else None +) if not (is_darwin_arm64 or is_windows) else None