fix: don't delete attached load balancers #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a load balancer is protected via the load-balancer-protect annotation, the load balancer will not be deleted when the service is removed. Signed-off-by: David Flanagan <david@rawkode.dev>
timoreimann
reviewed
Aug 1, 2022
There was a problem hiding this comment.
Thanks, this looks really good.
May I ask you to extend our annotation documentation at https://github.com/digitalocean/digitalocean-cloud-controller-manager/blob/master/docs/controllers/services/annotations.md as well?
|
Yeah. I'll get that updated |
|
@timoreimann Should be good to go |
|
I'll have another look soon, thanks. |
|
Apologies for having dropped the ball on this one. By now, I think there are out-of-band alternatives to generally protect resources from deletion, e.g., kyverno. I'm going to close out this PR as I think the involved complexity is better managed by such tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Load Balancer is attached via the load-balancer-id annotation,
thee CCM should not be responsible for deleting it as it was likely
provisioned by another means.
Signed-off-by: David Flanagan david@rawkode.dev
Closes #454