Add PostgreSQL configuration resource and test #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Exler <steffen@exivity.com>
Signed-off-by: Steffen Exler <steffen@exivity.com>
|
Taking a look now- thank you so much! Also, running |
danaelhe
reviewed
Apr 17, 2024
digitalocean/database/resource_database_postgres_config_test.go
Outdated
Show resolved
Hide resolved
danaelhe
reviewed
Apr 17, 2024
Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>
Signed-off-by: Steffen Exler <steffen@exivity.com>
Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>
|
Thanks for reviewing. I applied your suggestions. |
…_config Signed-off-by: Steffen Exler <steffen@exivity.com>
|
Thanks! Still working through the review- looks great though!! |
|
I had some time today so I pushed up some changes as well. Mostly minor things, like adding Thank you so much for your contribution! We should be able to get this merged and a new release cut today! |
danaelhe
approved these changes
Apr 18, 2024
linuxluigi
deleted the
feature/add-digitalocean_database_postgresql_config
branch
|
Thank you a lot @danaelhe 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new PostgreSQL configuration resource and a corresponding test. The resource allows users to configure various PostgreSQL settings for a DigitalOcean database cluster, similar like to MySQL.
I tried to implement all options from godo. For the test I'm not sure if they are working correct, I guess here it will need some more work.