chore: remove go.mod replace for old unused pkg #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
approved these changes
May 2, 2024
There was a problem hiding this comment.
👍 Thanks for the PR @yordis!
I did push an additional commit after running go mod vendor to update vendor/modules.txt
|
@andrewsomething thank you so much! Is there any opportunity to cut a release so that I can use it in the Crossplane Provider? I pinned the deps to my own repo but I would love to remove that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I am working on Crossplane DigitalOcean No Fork Upjet Provider that requires me to add this package as a dependency. I noticed this old package being pinned to an old version, so I had to deal with adding the
replacestatement to then realize that this package does not seem to be used.