Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional exclamation mark (!) #45

Closed
EndzeitBegins opened this issue Nov 12, 2021 · 0 comments
Closed

Add support for optional exclamation mark (!) #45

EndzeitBegins opened this issue Nov 12, 2021 · 0 comments

Comments

@EndzeitBegins
Copy link

As described in in an issue in the upstream repository, according to conventional commits, a breaking change can also be denoted by adding an exclamation mark (!) after type / scope.
This improves the visibility of breaking changes by making them visible in the commit message header.

fix(api)!: omit keys of undefined elements in JSON responses

BREAKING CHANGE: < reason here >

I'll open a PR which adds an option to enable this behaviour.
A code review would be highly appreciated.

Thanks in advance for the great work so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants