fix lint error with custom CSS class #2300
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2261 - this makes the linter pass all the checks. The issue is that "nextra" is some kind of indirect dependency for the website but two components are using
nextra-scrollbar
CSS class.I fixed this by adding this class to whitelist of the
tailwindcss/no-custom-classname
eslint rule.Description
I wanted to contribute to the project but was bothered that basic checks do not work. I decided to do this quick fix.
Fixes #2299
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
N/A
How Has This Been Tested?
Run
pnpm lint
on your local machine, all checks should pass. These checks should now also pass in CITest Environment:
@graphql-eslint/...
:"4.0.0-alpha.0"
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
Maybe the lint rule is correct and we shouldn't use the custom class name. But depending on
nextra
seems indirect, searching for it only yields results inpnpm-lock.yaml
. So to me, it even seems very suspicious, perhaps we could delete it?