Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README - outdated paragraph about Prettier #855

Closed
rtrembecky opened this issue Dec 17, 2021 · 4 comments
Closed

README - outdated paragraph about Prettier #855

rtrembecky opened this issue Dec 17, 2021 · 4 comments
Labels
kind/docs Improvements or additions to documentation

Comments

@rtrembecky
Copy link
Contributor

Context
Prettier is supported out-of-the-box from prettier/eslint-plugin-prettier#413.

Solution
Remove the related paragraph from README.

Alternatives
Add info that the Prettier-related changes are needed just for the older plugin versions.

Sorry for not creating a PR right away.

@rtrembecky rtrembecky changed the title Remove the paragraph about Prettier from README README - outdated paragraph about Prettier Dec 17, 2021
@dimaMachina dimaMachina added the kind/docs Improvements or additions to documentation label Dec 17, 2021
@dimaMachina
Copy link
Owner

Hi @rtrembecky, prettier/eslint-plugin-prettier#415 this PR must be merged also for removing unnecessary overrides

@rtrembecky
Copy link
Contributor Author

Does it? I don't know, I don't have any issues using eslint-plugin-prettier now without additional configuration, and the README is talking just about that plugin as well. So maybe it's a separate issue?
ref. README part: https://github.com/dotansimha/graphql-eslint#prettier-rule

@dimaMachina
Copy link
Owner

this is because your schema is located in graphql files, try to remove files: ['*.js/*.graphql'] override block in examples/prettier and you'll see different result - 31 errors vs 23 errors

@rtrembecky
Copy link
Contributor Author

Right, that would be it, thanks for the explanation. Closing this, I guess prettier/eslint-plugin-prettier#415 is enough to track this and it will be noticed when it gets merged 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants