Add support for Angular Universal #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'document' is not available during Server Side Rendering. By using the 'he' library we're no longer depending on the DOM to exist, adding support for Angular Universal.
|
Not sure what's causing CircleCI to fail. Dependencies have been included and tests run fine on a fresh environment. |
|
@dimpu sorry for bothering, bot any change of looking at this one? |
|
@dimpu any change of getting this merged? |
h3xx
approved these changes
Jul 21, 2021
|
@dirkgroenen Try this:
I re-wrote your commit to do all this if you look at #213. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentis not available during Server Side Rendering. By using the 'he' library we're no longer depending on the DOM to exist, adding support for Angular Universal.Fixes #149