Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share and fullscreen buttons are no longer available in version 5.4.3 #2100

Open
Ferdinandgushcloud opened this issue May 7, 2024 · 1 comment

Comments

@Ferdinandgushcloud
Copy link

Ferdinandgushcloud commented May 7, 2024

Hi All,

Currently, I am considering upgrading from version 4.1.3 to 5.4.3. I have noticed that the current version does not include the share and fullscreen features

<button class="pswp__button pswp__button--close" title="Close (Esc)"></button>
<button class="pswp__button pswp__button--share" title="Share"></button>
<button class="pswp__button pswp__button--fs" title="Toggle fullscreen"></button>
<button class="pswp__button pswp__button--zoom" title="Zoom in/out"></button>

I have reviewed the documentation, but perhaps I missed some information. I just want to confirm: does this latest version no longer provide the share and fullscreen features, as in version 4.1.3?

@dimsemenov
Copy link
Owner

Yes, that's correct. History API was removed as it's not reliable enough (too dependent on existing website routing and SEO/linking issues). And fullscreen feature was removed as it doubles existing behavior (e.g. click to open image and then click again to open it "more"). You can check this though for fullscreen https://photoswipe.com/native-fullscreen-on-open/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants