forked from detekt/detekt
/
CascadingCallWrappingSpec.kt
197 lines (165 loc) · 5.28 KB
/
CascadingCallWrappingSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
package io.gitlab.arturbosch.detekt.rules.style
import io.gitlab.arturbosch.detekt.api.Config
import io.gitlab.arturbosch.detekt.test.TestConfig
import io.gitlab.arturbosch.detekt.test.assertThat
import io.gitlab.arturbosch.detekt.test.compileAndLint
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
class CascadingCallWrappingSpec {
private val subject = CascadingCallWrapping(Config.empty)
@Test
fun `reports missing wrapping`() {
val code = """
val a = 0
.plus(0).plus(0).plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code))
.hasSize(1)
.hasTextLocations(23 to 30)
.first()
.hasMessage("Chained call `plus(0)` should be wrapped to a new line since preceding calls were.")
}
@Test
fun `does not report when chained calls are on a single line`() {
val code = """
val a = 0.plus(0).plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report wrapped calls`() {
val code = """
val a = 0
.plus(0)
.plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report unwrapped initial calls`() {
val code = """
val a = 0.plus(0).plus(0)
.plus(0)
.plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `reports missing wrapping for safe qualified calls`() {
val code = """
val a = 0
?.plus(0)?.plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports missing wrapping for calls with non-null assertions`() {
val code = """
val a = 0!!
.plus(0)!!.plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports missing wrapping for properties`() {
val code = """
val a = ""
.plus("").length
val b = ""
.length.plus(0)
""".trimIndent()
assertThat(subject.compileAndLint(code)).hasSize(2)
}
@Nested
inner class `with multiline calls` {
@Test
fun `does not report with wrapping`() {
val code = """
val a = 0
.plus(
0
)
.let {
0
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `reports missing wrapping`() {
val code = """
val a = 0
.plus(
0
)
.let {
0
}.plus(
0
)
""".trimIndent()
assertThat(subject.compileAndLint(code))
.hasTextLocations(65 to 86)
.hasSize(1)
}
@Test
fun `does not report when calls are multiline but never wrapped`() {
val code = """
val a = 0.plus(
0
).let {
0
}
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report for single multiline call`() {
val code = """
val a = 0.plus(
0
)
""".trimIndent()
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
@Nested
inner class `with elvis operators` {
private val subjectIncludingElvis = CascadingCallWrapping(TestConfig(mapOf("includeElvis" to true)))
private val subjectExcludingElvis = CascadingCallWrapping(TestConfig(mapOf("includeElvis" to false)))
@Test
fun `does not report with wrapping`() {
val code = """
val a = 0
.plus(0)
?: 0
""".trimIndent()
assertThat(subjectIncludingElvis.compileAndLint(code)).isEmpty()
assertThat(subjectExcludingElvis.compileAndLint(code)).isEmpty()
}
@Test
fun `reports missing wrapping`() {
val code = """
val a = 0
.plus(0) ?: 42
""".trimIndent()
assertThat(subjectIncludingElvis.compileAndLint(code))
.hasTextLocations(23 to 28)
.hasSize(1)
assertThat(subjectExcludingElvis.compileAndLint(code)).isEmpty()
}
@Test
fun `reports missing wrapping multiline call`() {
val code = """
val a = 0
.plus(0) ?: let {
42
}
""".trimIndent()
assertThat(subjectIncludingElvis.compileAndLint(code))
.hasTextLocations(23 to 38)
.hasSize(1)
assertThat(subjectExcludingElvis.compileAndLint(code)).isEmpty()
}
}
}