Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations removed when added new field to data model #10312

Closed
3 tasks done
liho00 opened this issue Dec 5, 2021 · 7 comments
Closed
3 tasks done

Translations removed when added new field to data model #10312

liho00 opened this issue Dec 5, 2021 · 7 comments

Comments

@liho00
Copy link

liho00 commented Dec 5, 2021

Preflight Checklist

Describe the Bug

Translations content missing when added a new field to data model. Besides, deleting the field also removed the translation contents.

Imagine in production, I have hundred posts with keyed in translation contents, and the contents missing after added a single new field. The writer & developer will be having a hard time.

To Reproduce

  1. add new content to translation field.
  2. go to the data model, add a new file field.
  3. go back to content dashboard, the translation is removed.

video demostration

Untitled.mp4

Errors Shown

checked no error.

What version of Directus are you using?

9.2.0 (checked latest version 9.2.0)

What version of Node.js are you using?

14.17.1

What database are you using?

SQLite3 v5.0.2

What browser are you using?

chrome

What operating system are you using?

macOS Big Sur (11)

How are you deploying Directus?

locally

@liho00 liho00 changed the title Translations missing when added new field to data model Translations removed when added new field to data model Dec 5, 2021
@licitdev
Copy link
Member

licitdev commented Dec 6, 2021

@liho00 Thank you for your report.

Notes

@azrikahar
Copy link
Contributor

As @licitdev pointed out, this is indeed a knex+sqlite specific issue with a more-recent duplicate #9987, and currently it's tracked over at knex/knex#4155 with in-works PR knex/knex#4189.

Hopefully this comment #8142 (comment) can shed some light on it as well.

@liho00
Copy link
Author

liho00 commented Dec 6, 2021

As @licitdev pointed out, this is indeed a knex+sqlite specific issue with a more-recent duplicate #9987, and currently it's tracked over at knex/knex#4155 with in-works PR knex/knex#4189.

Hopefully this comment #8142 (comment) can shed some light on it as well.

@azrikahar Since you said its sqlite specific issue, I have a question on it, because im now looking for alternate solution.

Can i merge the pr locally? cuz i saw the PR has been created about a year, but not yet merge.

Or can i use postgresql instead of sqlite? Just want to double confirm postgresql does not having this issue before i migrate the database.

Could you advise a better solution here? Thanks in advance.

@azrikahar
Copy link
Contributor

Can i merge the pr locally? cuz i saw the PR has been created about a year, but not yet merge.

Unfortunately I can't confirm it'll work as it is still a draft.

Or can i use postgresql instead of sqlite? Just want to double confirm postgresql does not having this issue before i migrate the database.

Yup! Postgresql will not have this specific issue, so rest assured 👍

@firatoezcan
Copy link

Can this be merged now? The knex issue is merged and it makes it seem like the application just doesnt handle that case when evaluating the free tier on the cloud.

If I wouldn't have found this issue, I would have dismissed Directus as a viable option now and I can imagine more people would think the same (which is sad because everything else is super nice, it just makes it seem like an issue)

@rijkvanzanten
Copy link
Member

Can this be merged now? The knex issue is merged and it makes it seem like the application just doesnt handle that case when evaluating the free tier on the cloud.

If I wouldn't have found this issue, I would have dismissed Directus as a viable option now and I can imagine more people would think the same (which is sad because everything else is super nice, it just makes it seem like an issue)

Yeah! We fixed the underlying issue on the knex side of things, but there was another big breaking change in knex itself that prevented us from upgrading it Directus side earlier. We're tracking the efforts over on #10842 🙂

@firatoezcan
Copy link

firatoezcan commented Apr 27, 2022

Can this be merged now? The knex issue is merged and it makes it seem like the application just doesnt handle that case when evaluating the free tier on the cloud.
If I wouldn't have found this issue, I would have dismissed Directus as a viable option now and I can imagine more people would think the same (which is sad because everything else is super nice, it just makes it seem like an issue)

Yeah! We fixed the underlying issue on the knex side of things, but there was another big breaking change in knex itself that prevented us from upgrading it Directus side earlier. We're tracking the efforts over on #10842 slightly_smiling_face

Ah well, then at least future people know where to look at. Thanks for the pointer!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants