Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon path not relative to public_url #20414

Open
danielohling opened this issue Nov 13, 2023 · 6 comments
Open

Favicon path not relative to public_url #20414

danielohling opened this issue Nov 13, 2023 · 6 comments
Labels

Comments

@danielohling
Copy link

Describe the Bug

From what I can see in the network tab, directus tries to get the favicon from /root/ path instead of what is specified in public_url.

I run nginx and directus as a subfolder with proxy_pass on route /Api.

My main application is on the root path ./.

see print screens below:

Favicon /root path

Project Logo correct Path

Vue Router log error

I'm thinking it should fetch the favicon the same way as project_logo? and respect the path in public_url

To Reproduce

Add a new favicon i settings and logout och refresh the page.

Directus Version

v10.7.2

Hosting Strategy

Self-Hosted (Docker Image)

@rijkvanzanten
Copy link
Member

I believe that's just the browser's default /favicon.ico load that kicks in before Directus' JS sets the favicon based on the settings 🤔

@robinsonjohn

This comment was marked as off-topic.

@hanneskuettner

This comment was marked as off-topic.

@robinsonjohn

This comment was marked as off-topic.

@hanneskuettner

This comment was marked as off-topic.

@divStar
Copy link

divStar commented May 25, 2024

I apologize in advance, but why is the "default favicon.ico" even kicking in?
I do have a SVG logo and the path https://directus-mycv.my.family/assets/c846e6d3-2c6b-47ce-84da-637b3cd12e9b is valid (in my network). Copying and pasting it, displays the SVG.

The tag is in the HTML header:

<link rel="icon" href="https://directus-mycv.my.family/assets/c846e6d3-2c6b-47ce-84da-637b3cd12e9b">

According to https://caniuse.com/link-icon-svg I can use SVG favicons (I am on MacOS 14.4 and Firefox 125.0.3). It probably should display the icon, yet I receive the following:

{
	"errors": [
		{
			"message": "Route /favicon.ico doesn't exist.",
			"extensions": {
				"code": "ROUTE_NOT_FOUND",
				"path": "/favicon.ico"
			}
		}
	]
}

Nevertheless: the icon does display in the tab properly, but when creating a bookmark, it sadly does not display at all. Any idea what I am doing wrong?
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants