source_env: show full path #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have already stumbled across this several times. If you have an ".envrc.local" in both directories, you get the same logging twice, which often leads to the assumption that the same file is sourced twice. |
yermulnik
reviewed
Apr 6, 2022
stdlib.sh
Outdated
| @@ -346,7 +346,7 @@ source_env() { | |||
| pushd "$(pwd 2>/dev/null)" >/dev/null || return 1 | |||
| pushd "$rcpath_dir" >/dev/null || return 1 | |||
| if [[ -f ./$rcpath_base ]]; then | |||
| log_status "loading $rcfile" | |||
| log_status "loading $(expand_path "$rcpath")" | |||
There was a problem hiding this comment.
Should the expand_path be amended to show ~ instead of user home path?
Kind of:
Suggested change
| log_status "loading $(expand_path "$rcpath")" | |
| log_status "loading $(expand_path "$rcpath" | sed 's|^'${HOME:=none}'|~|')" |
There was a problem hiding this comment.
@yermulnik thanks for catching the regression! user_rel_path did it eventually.
Before: Given ~/path/to/.envrc containing: source_env .envrc.local When doing `direnv exec ~/path/to true` it shows: direnv: loading .envrc.local After: It shows: direnv: loading ~/path/to/.envrc.local
|
@zimbatm thoughts on this one? 🙏🏻 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths passed to
source_env(_if_exists)are logged as-is, e.g..envrc.local.This PR ensures the full path is logged, like with
source_up.