Support custom VIRTUAL_ENV for layout_python #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind adding some tests as well? The function is getting pretty large and I am not confident it will work in all scenarios. |
|
Thank you for the reply. I will try that. |
|
bump |
|
the macOS CI is failing. It looks like venv is missing there? |
|
Seems to be fixed now. Can you run CI again? |
zimbatm
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify
VIRTUAL_ENVenvironment variable forlayout_pythonandlayout_pyenv.The behavior is along with the wiki page.
Usage:
Fix #616