Ensure status log messages are printed with normal color #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset color for normal status messages.
zimbatm
force-pushed
the
log_status_normal_color
branch
from
a6868a8
to
22923a8
Compare
|
Thanks, I just rebased the PR to use escape codes instead so it doesn't depend on curses to function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset color for normal status messages.
This might helps in a case when an evaluated command has not cleaned up after itself. But also makes it possible to add support for coloring all stderr output (#885).
While at it, also set variables in
log_error()only if needed