Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shell_elvish.go to the newer (non-deprecated) Elvish syntax #896

Merged
merged 2 commits into from Apr 21, 2022
Merged

Update shell_elvish.go to the newer (non-deprecated) Elvish syntax #896

merged 2 commits into from Apr 21, 2022

Conversation

icidasset
Copy link
Contributor

mmlb
mmlb reviewed Mar 21, 2022
View reviewed changes
Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimbatm this lgtm as an elvish user.

@grawlinson grawlinson mentioned this pull request Mar 27, 2022
Open
@zimbatm
Copy link
Member

zimbatm commented Mar 27, 2022

@icidasset do you mind rebasing? I'm not sure why the CI didn't run.

@icidasset
Copy link
Contributor Author

@icidasset do you mind rebasing? I'm not sure why the CI didn't run.

Done 👀

@zimbatm zimbatm merged commit e5a6e4c into direnv:master Apr 21, 2022
@zimbatm
Copy link
Member

zimbatm commented Apr 21, 2022

thanks!

@zimbatm zimbatm mentioned this pull request Apr 21, 2022
Closed
@avioli
Copy link

avioli commented May 25, 2022

Since 0.18.0 - syntax should be try {} catch e {}, not try {} except e {}, since except is now deprecated and will be removed from 0.19.0

@zimbatm
Copy link
Member

zimbatm commented May 25, 2022 •
edited

Do you mind sending a PR? I will do a release afterwards. you already did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmlb mmlb mmlb left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@icidasset @zimbatm @avioli @mmlb