-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Reaction roles bot example #3361
base: main
Are you sure you want to change the base?
Conversation
And fix lint-staged and eslint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3361 +/- ##
==========================================
- Coverage 76.72% 74.34% -2.39%
==========================================
Files 193 193
Lines 23384 23400 +16
Branches 763 677 -86
==========================================
- Hits 17941 17396 -545
- Misses 5434 5995 +561
Partials 9 9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ff809d2
to
a207593
Compare
+ code changes accordingly
I have to thank @tsClauz for helping me with the reactionroles.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Merge this once tests pass |
Co-authored-by: LTS20050703 <lts20050703@gmail.com>
Co-authored-by: LTS20050703 <lts20050703@gmail.com>
Co-authored-by: LTS20050703 <lts20050703@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't want to overwhelm you yesterday, so here's the second and final part of my review.
Co-authored-by: LTS20050703 <lts20050703@gmail.com>
Also add the tsconfig for the reaction roles example as i forgot it and was using the root dir one
Closes #2819
Depends on #3355