You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just wanted to take a moment to go through some of the labels and label groups and share some thoughts.
Starting with [HELP WANTED] good first issue. I've beat this one into the ground but I'll put it officially on paper. It makes no sense, to me, to be one label. help wanted can apply to issues which may not be good first issue for users. For example, I'd probably leave non-priority good first issue issues to new contributors while wanting to seek out other issues in need of attention. Right now there's no way of doing this.
Before: [HELP WANTED] good first issue
My recommendation: help wanted, good first issue
Speed run through the rest of them, if I understand what they're for and my comments:
p-X: Plugins, I assume we'll still need this at some point.
pkg-X: Packages in the monorepo
t-X: Type? Why not just type-X? It's just one more letter that pkg-X, I think this would be an improvement and increase in clarity
template: makes sense, just is template changes
w-X: No clue, am I just blind? I know the purpose of the labels, but I have no clue what the w is.
i-X: There's only one label with this, i-duplicate, is this referring issue? Why not put w labels in here?
bulk-pr-meister: I see this was used once, is this label still needed? It seemed like a one-off
docs-commit-without-effect: I guess I just don't understand the naming. Why not make it like a "child" of api-docs-commits like api-docs-commits-no-impact or something. I guess there's no real issue but even after reading the description I had to still go to the issues it was assigned to so I could see what it means. That may just be a me thing though, so no biggie.
Documenting the labels I think is important as a contributor, especially when you're auto-labeling or have multiple types. Might be worth adding something to contributing like Black, PowerShell, NextJS (in a way). Could expand the contributing to the current page being intro and the rest as "further reading" as reference pages or just supplemental documentation on things such as this. I don't think DD needs as detailed documentation as some of these repos, but it would be nice to have like "cheat sheets."
If I think of anything else, I'll add comments.
The text was updated successfully, but these errors were encountered:
About help wanted I agree. We should have 2 labels: help-wantedgood-first-issue.
About the labels with prefixes, those are just meant to group them together in the List. Yes they do have a deeper meaning too, but that's not something anyone needs to know in order to contribute. Since labels are assigned by the members of the org, or automatically by a bot.
Labels which are not used anymore like bulk-pr-meister can be marked as deprecated.
docs-commit-without-effect can indeed be renamed to irrelevant-api-docs-commits
@itohatweb that's where I was looking. which is when going through the labels most made sense.
Could at least be worth pointing to the list in the documentation.
This has been brought up before and it's something I know I personally have issues with. I know my coworker also expressed confusion about it too.
I just wanted to take a moment to go through some of the labels and label groups and share some thoughts.
Starting with
[HELP WANTED] good first issue
. I've beat this one into the ground but I'll put it officially on paper. It makes no sense, to me, to be one label.help wanted
can apply to issues which may not begood first issue
for users. For example, I'd probably leave non-prioritygood first issue
issues to new contributors while wanting to seek out other issues in need of attention. Right now there's no way of doing this.Before:
[HELP WANTED] good first issue
My recommendation:
help wanted
,good first issue
Speed run through the rest of them, if I understand what they're for and my comments:
p-X
: Plugins, I assume we'll still need this at some point.pkg-X
: Packages in the monorepot-X
: Type? Why not justtype-X
? It's just one more letter thatpkg-X
, I think this would be an improvement and increase in claritytemplate
: makes sense, just is template changesw-X
: No clue, am I just blind? I know the purpose of the labels, but I have no clue what thew
is.i-X
: There's only one label with this,i-duplicate
, is this referringissue
? Why not putw
labels in here?bulk-pr-meister
: I see this was used once, is this label still needed? It seemed like a one-offdocs-commit-without-effect
: I guess I just don't understand the naming. Why not make it like a "child" ofapi-docs-commits
likeapi-docs-commits-no-impact
or something. I guess there's no real issue but even after reading the description I had to still go to the issues it was assigned to so I could see what it means. That may just be a me thing though, so no biggie.Documenting the labels I think is important as a contributor, especially when you're auto-labeling or have multiple types. Might be worth adding something to contributing like Black, PowerShell, NextJS (in a way). Could expand the contributing to the current page being intro and the rest as "further reading" as reference pages or just supplemental documentation on things such as this. I don't think DD needs as detailed documentation as some of these repos, but it would be nice to have like "cheat sheets."
If I think of anything else, I'll add comments.
The text was updated successfully, but these errors were encountered: