Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js v20 にする。？ #18

Closed
Mogyuchi opened this issue Nov 24, 2023 · 3 comments · Fixed by #26
Closed

Node.js v20 にする。？ #18

Mogyuchi opened this issue Nov 24, 2023 · 3 comments · Fixed by #26

Comments

@Mogyuchi
Copy link
Collaborator

No description provided.

@femshima
Copy link
Contributor

femshima commented Nov 25, 2023 •
edited

@discordjs/opusにNode 20用のprebuildがないので，amd64でaarch64向けのDockerコンテナを作る際，クロスコンパイルが要りそうです．
@discordjs/opusが対応するまでを凌ぐためのコード（具体的にはGitHub Actions）を書くよりは，18系を維持するほうが楽な気はします．

一方で@discordjs/opusにコントリビュートすべきだというのはそうで…

@cm-ayf
Copy link
Collaborator

cm-ayf commented Nov 26, 2023

discordjs/opus#148

@cm-ayf
Copy link
Collaborator

cm-ayf commented Dec 7, 2023

#22

@femshima femshima mentioned this issue Dec 11, 2023
Merged
cm-ayf pushed a commit that referenced this issue Dec 12, 2023
@femshima
build: update node to v20 (#26)
ef3a636 
Closes #18 

Release-As: 0.1.1

debian 12を採用していることによりopusのprebuildが利用できていないため，実はNode
20に上げても上げなくてもopusのビルドは走っていたようです．

なお，`20.10.0`ではなく`20.10.0-bookworm`としたのは，depsステージでもdebian
12を使わせるためです．現在は最新版がbookwormなので違いはありませんが，今後新しいバージョンが出てきたときに壊れないよう，bookwormに固定します．
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: update node to v20 femshima/djsjapan-om
3 participants
@femshima @Mogyuchi @cm-ayf