Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

Validation errors #71

Open
KokoNeotSide opened this issue Jan 1, 2022 · 3 comments
Open

Validation errors #71

KokoNeotSide opened this issue Jan 1, 2022 · 3 comments

Comments

@KokoNeotSide
Copy link

KokoNeotSide commented Jan 1, 2022

Feature

Please revert back the validation errors. This new "Zod" thing is terrible. I've been searching for 2h where the issue is because it doesn't tell you where the error is.

Ideal solution or implementation

Revert back to the previous validator (ow) which said what exact fields and commands are causing issues

Alternative solutions or implementations

No response

Other context

image
image

the first image, I'm missing description for one command, there is no way for me to read that from the error.
the second image, I accidentally made one command name first letter capital. All I know that my regex is invalid somewhere in 50 commands. This is terrible

@kyranet
Copy link
Member

kyranet commented Jan 1, 2022

That's not happening, ow switched to ESM-only and has caused many issues in the past due to it.

We'll most likely switch to ShapeShift, which Sapphire devs have been building to improve the experience and performance of the validation process.

@KhafraDev
Copy link
Contributor

KhafraDev commented Jan 1, 2022

@kyranet Are there any benchmarks for shapeshift compared to zod or other validation libs?

@kyranet
Copy link
Member

kyranet commented Jan 1, 2022

Yes, @vladfrangu has them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants