Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RESTPatchAPIGuildMember): add modify current member and deprecate nick route #262

Merged
merged 8 commits into from Jan 9, 2022

Conversation

BenjammingKirby
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
adds support for the Modify Current Member to the guildMember function
also adds a deprecation warning for Modify Current User Nick

fixes #261
Reference Discord API Docs PRs or commits:

@BenjammingKirby
Copy link
Contributor Author

I also only added the deprecation warnings for the v9 files, I wasn't sure if they should be added for v8 as well

@vladfrangu
Copy link
Member

They should be added to v8 too

deno/rest/v8/guild.ts Show resolved Hide resolved
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new lines where I reviewed 🙏

rest/v8/guild.ts Outdated Show resolved Hide resolved
rest/v9/guild.ts Outdated Show resolved Hide resolved
@BenjammingKirby
Copy link
Contributor Author

Please add new lines where I reviewed 🙏

done, also I forgot to link to the documentation on the new interfaces apparently, that too has been added

deno/rest/v9/mod.ts Outdated Show resolved Hide resolved
BenjammingKirby and others added 2 commits December 16, 2021 05:05
Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
deno/rest/v8/guild.ts Outdated Show resolved Hide resolved
@vladfrangu vladfrangu changed the title feat(guildmember): add modify current member feat(RESTPatchAPIGuildMember): add modify current member and deprecate nick route Jan 9, 2022
@vladfrangu vladfrangu merged commit 9a982ff into discordjs:main Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route documentation inconsistent for "Modify Current Member"
5 participants