fix(APIInteraction): add modal submit interaction & make data required in APIModalSubmit
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Feb 11, 2022
vladfrangu
requested changes
Feb 11, 2022
|
Might also need to check if it's similar to chat input commands with DM/Guild interactions 👀 |
almeidx
changed the title
APIInteraction union & make data required
vladfrangu
requested changes
Feb 11, 2022
almeidx
force-pushed
the
interaction-type-fix
branch
from
a34b3ec
to
0625d46
Compare
vladfrangu
approved these changes
Feb 11, 2022
|
Looks great! Found the same missing guild/dm interactions for autocompletes that anyone can fix in a subsequent PR 👀 |
vladfrangu
changed the title
APIInteraction union & make data requireddata required in APIModalSubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Reference Discord API Docs PRs or commits:
datais always present on modal submit interactions discord/discord-api-docs#4486