Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIGuildForum): add support for forums, part 1 #398

Merged
merged 8 commits into from Apr 10, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Add initial support for forums given documentation in the docs PR.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

deno/payloads/v10/channel.ts Show resolved Hide resolved
deno/rest/common.ts Show resolved Hide resolved
deno/rest/v10/mod.ts Outdated Show resolved Hide resolved
@vladfrangu
Copy link
Member

Tis needs a rebase

@vladfrangu vladfrangu self-requested a review April 7, 2022 11:59
@suneettipirneni
Copy link
Member Author

Upstream PR landed

Copy link
Contributor

@vvito7 vvito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong links.

deno/payloads/v10/channel.ts Outdated Show resolved Hide resolved
deno/payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v10/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
deno/rest/v9/channel.ts Show resolved Hide resolved
Copy link
Contributor

@vvito7 vvito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated types. 👀

deno/payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
@vladfrangu vladfrangu changed the title feat(forum): add support for forums, part 1 feat(APIGuildForum): add support for forums, part 1 Apr 10, 2022
@vladfrangu vladfrangu merged commit bf08484 into discordjs:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants