Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APIApplicationCommandStringOption): add min_length and max_length #513

Merged
merged 2 commits into from Jul 2, 2022
Merged

feat(APIApplicationCommandStringOption): add min_length and max_length #513

merged 2 commits into from Jul 2, 2022

Conversation

Mateo-tem
Copy link
Contributor

@Mateo-tem Mateo-tem commented Jul 2, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

Adds min_length and max_length fields to APIApplicationCommandStringOption.
Closes #512.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Jul 2, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Jul 2, 2022 at 1:02AM (UTC)

@ImRodry
Copy link
Contributor

ImRodry commented Jul 2, 2022

Please use a closing keyword

@Mateo-tem
Copy link
Contributor Author

Please use a closing keyword

Oh ok, thank you!

@imranbarbhuiya imranbarbhuiya mentioned this pull request Jul 2, 2022
Merged
vladfrangu
vladfrangu approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at some point we should make this a common interface between the 3 types

@vladfrangu vladfrangu merged commit 2cade98 into discordjs:main Jul 2, 2022
@Mateo-tem Mateo-tem deleted the feat/string-min-max-length branch July 2, 2022 15:15
@vvito7
Copy link
Contributor

vvito7 commented Jul 2, 2022

at some point we should make this a common interface between the 3 types

What do you mean? 👀
These fields are only present in STRING type, did you maybe misread? There are min_value & max_value (pretty similar names) fields that are present in INTEGER & NUMBER types

@vladfrangu
Copy link
Member

Had the same brainfart as in discord.js, so ignore that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
semver:minor topic:payloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application Command Option Data (min_length, max_length)
5 participants
@Mateo-tem @ImRodry @vvito7 @vladfrangu @kyranet