Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormattingPatterns): add ApplicationCommand #525

Merged
merged 8 commits into from Aug 23, 2022

Conversation

vvito7
Copy link
Contributor

@vvito7 vvito7 commented Jul 13, 2022

Please describe the changes this PR makes and why it should be merged:
Adds ApplicationCommand format to FormattingPatterns constant.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 8:55PM (UTC)

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to match the command name regular expression? How come it's just \w{2,32}? Is that actually right?

@vvito7
Copy link
Contributor Author

vvito7 commented Jul 13, 2022

Yes, you are right, going to change it right now

globals.ts Outdated Show resolved Hide resolved
globals.ts Outdated Show resolved Hide resolved
deno/globals.ts Outdated Show resolved Hide resolved
vvito7 and others added 2 commits July 14, 2022 10:28
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@vladfrangu vladfrangu merged commit 0098889 into discordjs:main Aug 23, 2022
@vvito7 vvito7 deleted the command-format branch August 24, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants