Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GatewayGuildMembersChunkDispatchData): make chunk pagination properties mandatory #558

Merged
merged 1 commit into from Aug 9, 2022

Conversation

aetheryx
Copy link
Contributor

@aetheryx aetheryx commented Aug 9, 2022

…perties mandatory

properties are listed as required on the documentation: https://discord.com/developers/docs/topics/gateway#guild-members-chunk
and seem to be regardless of nonce

2022-08-09 14:54:18.513  INFO  [src/shard/guild-member-handler.ts:58] sending guild member request 
{
  guild_id: '917075127139717200',
  query: 'a',
  limit: 1
}
2022-08-09 14:54:18.650  INFO  [src/shard/guild-member-handler.ts:25] received chunk 
{
  members: [
    {
      // ...
    }
  ],
  guild_id: '917075127139717200',
  chunk_index: 0,
  chunk_count: 1
}
2022-08-09 14:54:33.672  INFO  [src/shard/guild-member-handler.ts:58] sending guild member request 
{
  guild_id: '917075127139717200',
  query: 'a',
  limit: 1,
  nonce: '_a'
}
2022-08-09 14:54:33.819  INFO  [src/shard/guild-member-handler.ts:25] received chunk 
{
  nonce: '_a',
  members: [
    {
      // ...
    }
  ],
  guild_id: '917075127139717200',
  chunk_index: 0,
  chunk_count: 1
}
2022-08-09 14:54:51.037  INFO  [src/shard/guild-member-handler.ts:58] sending guild member request 
{
  guild_id: '917075127139717200',
  user_ids: [
    '284122164582416385'
  ]
}
2022-08-09 14:54:51.158  INFO  [src/shard/guild-member-handler.ts:25] received chunk 
{
  not_found: [],
  members: [
    {
      // ...
    }
  ],
  guild_id: '917075127139717200',
  chunk_index: 0,
  chunk_count: 1
}
2022-08-09 14:54:55.655  INFO  [src/shard/guild-member-handler.ts:58] sending guild member request 
{
  guild_id: '917075127139717200',
  user_ids: [
    '284122164582416385'
  ],
  nonce: '_b'
}
2022-08-09 14:54:55.777  INFO  [src/shard/guild-member-handler.ts:25] received chunk 
{
  not_found: [],
  nonce: '_b',
  members: [
    {
      // ...
    }
  ],
  guild_id: '917075127139717200',
  chunk_index: 0,
  chunk_count: 1
}

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 3:46PM (UTC)

@vladfrangu vladfrangu changed the title feat(GatewayGuildMembersChunkDispatchData): make chunk pagination pro… fix(GatewayGuildMembersChunkDispatchData): make chunk pagination properties mandatory Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants