Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIGuildIntegration): add scopes #563

Merged
merged 4 commits into from Aug 29, 2022
Merged

Conversation

vvito7
Copy link
Contributor

@vvito7 vvito7 commented Aug 12, 2022

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ❌ Failed (Inspect) Aug 15, 2022 at 8:17PM (UTC)

Copy link

@ooliver1 ooliver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about optional/nullable since I don't have access to a youtube/twitch integration to test with, just assuming it's optional.

So you should make scopes nullable either via ? or null depending on what kind of optional it is.

@vladfrangu vladfrangu merged commit 73d15dd into discordjs:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants