Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APIGuildForumChannel): update and add missing features #575

Merged
merged 23 commits into from Sep 25, 2022
Merged

feat(APIGuildForumChannel): update and add missing features #575

merged 23 commits into from Sep 25, 2022

Conversation

Mateo-tem
Copy link
Contributor

@Mateo-tem Mateo-tem commented Aug 29, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

This would be the second and final part of #398, adding support for forum channels.

Note: Maybe you can see that in the first commit are different descriptions on the fields than in the upstream PR. I've already made a draft of this in the previous days, I just replaced all of those, and it's synced now!

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Aug 29, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 1:39AM (UTC)

vvito7
vvito7 reviewed Aug 31, 2022
View reviewed changes
deno/rest/common.ts Outdated Show resolved Hide resolved
@vladfrangu
Copy link
Member

Per discussing with devs:

@Mateo-tem
Copy link
Contributor Author

  • In RESTPatchAPIGuildChannelJSONBody:

    • Please add a documentation warning for the tags properties that the id is optional when creating new tags (so they can set it to "0")

I've tried making a PATCH request to edit a forum channel and only the name property is required for new tags. Then, the id will be generated automatically and will be returned in the available_tags property along with the tag objects in the payload (the new forum channel).

@Mateo-tem
Copy link
Contributor Author

  • In RESTPatchAPIGuildChannelJSONBody:

    • Please add a documentation warning for the tags properties that the id is optional when creating new tags (so they can set it to "0")

@Jiralite Jiralite mentioned this pull request Sep 16, 2022
Merged
@almeidx
Copy link
Member

almeidx commented Sep 17, 2022 •
edited

Can you add this as well? If not, it can be done in a separate pull request

@almeidx almeidx mentioned this pull request Sep 18, 2022
Merged
@almeidx
Copy link
Member

almeidx commented Sep 19, 2022

Needs some updates to reflect the changes made in

@almeidx
Copy link
Member

almeidx commented Sep 20, 2022

And again!

Maybe just revert the default_sort_order changes so this PR doesn't get blocked for the rest of eternity?

@vladfrangu vladfrangu merged commit 0f118d3 into discordjs:main Sep 25, 2022
@Mateo-tem Mateo-tem deleted the feat/update-forum-docs branch September 25, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvito7 vvito7 vvito7 left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@kyranet kyranet Awaiting requested review from kyranet

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
semver:minor topic:payloads topic:rest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mateo-tem @vladfrangu @almeidx @vvito7