Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UserPremiumType): add NitroBasic #616

Merged
merged 3 commits into from Oct 27, 2022

Conversation

Mateo-tem
Copy link
Contributor

@Mateo-tem Mateo-tem commented Oct 20, 2022

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 10:44PM (UTC)

@Jiralite
Copy link
Member

Is this actually right? Isn't this completely breaking?

@Mateo-tem
Copy link
Contributor Author

Is this actually right? Isn't this completely breaking?

This is supposed to be right, Nitro Basic was officially announced and is being rolled out since today. Discord is using PREMIUM_TIER_0 for Nitro Basic.

@Jiralite
Copy link
Member

I think I interpreted 0 as no Nitro rather than unused, I guess...

@Mateo-tem
Copy link
Contributor Author

Mateo-tem commented Oct 20, 2022

Now, if you don't have Nitro, the user object will return the premium_type property as null (correct me if I am wrong).

@vvito7
Copy link
Contributor

vvito7 commented Oct 20, 2022

It wouldn't really make sense, discord/discord-api-docs#5568 is probably the way it is being done

@panley01
Copy link
Contributor

panley01 commented Oct 20, 2022

I bought the new nitro to check and, yep, comes in as 3

afaik it was 0 with no nitro being set to -1 or the field being made nullable but that caused too many issues because it was (obviously) a breaking change. As of the rollout this week, it's 3. No nitro is still 0.

@Mateo-tem
Copy link
Contributor Author

Mateo-tem commented Oct 21, 2022

Oh, well, it seems to be a last-minute change, I found this, it should be the cause of the change?
discord com_channels_613425648685547541_697216494760886393

@Mateo-tem
Copy link
Contributor Author

I bought Nitro Basic and now I can confirm that it is 3. I will change it and sorry for the confusion.

@vladfrangu vladfrangu merged commit 9448e9b into discordjs:main Oct 27, 2022
@Mateo-tem Mateo-tem deleted the feat/nitro-basic branch October 27, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants