Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing gateway dispatch payloads to gateway event union #619

Merged
merged 7 commits into from Oct 27, 2022
Merged

fix: add missing gateway dispatch payloads to gateway event union #619

merged 7 commits into from Oct 27, 2022

Conversation

john-batch
Copy link
Contributor

@vercel
Copy link

vercel bot commented Oct 21, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 3:44PM (UTC)

@john-batch john-batch mentioned this pull request Oct 21, 2022
Closed
@vladfrangu
Copy link
Member

If this PR closes #617 then please mark it as such! 🙏

@john-batch
Copy link
Contributor Author

I will, but I noticed that GatewayDispatchPayload doesn't include all dispatch payloads in the union, namely :

GatewayAutoModerationRuleModifyDispatch
GatewayAutoModerationRuleCreateDispatch
GatewayAutoModerationRuleDeleteDispatch
GatewayAutoModerationActionExecutionDispatch

They're already declared in gateway/v10, so do you want me to add them to the union as part of this PR or to create a new one ?

@vladfrangu
Copy link
Member

Do it in this PR if you can! 🙏

@kyranet kyranet linked an issue Oct 23, 2022 that may be closed by this pull request
Interface to associate GatewayDispatchEvents and relevant DataPayload (proposed code below) #617
Closed
@vladfrangu
Copy link
Member

Can you do this for v9 too or is it not needed there?

@john-batch
Copy link
Contributor Author

Should I add GatewayApplicationCommandPermissionsUpdateDispatch to the v9 declaration as well ? I'm not too familiar with how application commands works in v9.

@vladfrangu
Copy link
Member

The only differences between API v9 and v10 is threads! So, yes please!

@vladfrangu vladfrangu enabled auto-merge (squash) October 27, 2022 18:15
@vladfrangu vladfrangu changed the title feat: add GatewayApplicationCommandPermissionsUpdateDispatch fix: add missing gateway dispatch payloads to gateway event union Oct 27, 2022
@vladfrangu vladfrangu enabled auto-merge (squash) October 27, 2022 18:15
@vladfrangu vladfrangu merged commit 348dd41 into discordjs:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
semver:patch topic:gateway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface to associate GatewayDispatchEvents and relevant DataPayload (proposed code below)
3 participants
@john-batch @vladfrangu @kyranet