From 14bbc9150a748e7ac1660c2375c7f065fcc55a6c Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Mon, 19 Sep 2022 21:00:59 +0100 Subject: [PATCH] types: Narrow channel type in thread managers (#8640) types: narrow channel type in thread managers Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --- packages/discord.js/src/managers/GuildForumThreadManager.js | 6 ++++++ packages/discord.js/src/managers/GuildTextThreadManager.js | 6 ++++++ packages/discord.js/src/managers/ThreadManager.js | 2 +- packages/discord.js/typings/index.d.ts | 6 ++++-- 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/packages/discord.js/src/managers/GuildForumThreadManager.js b/packages/discord.js/src/managers/GuildForumThreadManager.js index d124e8b82ae3..03f87319400f 100644 --- a/packages/discord.js/src/managers/GuildForumThreadManager.js +++ b/packages/discord.js/src/managers/GuildForumThreadManager.js @@ -10,6 +10,12 @@ const MessagePayload = require('../structures/MessagePayload'); * @extends {ThreadManager} */ class GuildForumThreadManager extends ThreadManager { + /** + * The channel this Manager belongs to + * @name GuildForumThreadManager#channel + * @type {ForumChannel} + */ + /** * @typedef {BaseMessageOptions} GuildForumThreadCreateOptions * @property {stickers} [stickers] The stickers to send with the message diff --git a/packages/discord.js/src/managers/GuildTextThreadManager.js b/packages/discord.js/src/managers/GuildTextThreadManager.js index 8c340e06a9bb..1d8924991c45 100644 --- a/packages/discord.js/src/managers/GuildTextThreadManager.js +++ b/packages/discord.js/src/managers/GuildTextThreadManager.js @@ -9,6 +9,12 @@ const { ErrorCodes, TypeError } = require('../errors'); * @extends {ThreadManager} */ class GuildTextThreadManager extends ThreadManager { + /** + * The channel this Manager belongs to + * @name GuildTextThreadManager#channel + * @type {TextChannel|NewsChannel} + */ + /** * Options for creating a thread. Only one of `startMessage` or `type` can be defined. * @typedef {StartThreadOptions} ThreadCreateOptions diff --git a/packages/discord.js/src/managers/ThreadManager.js b/packages/discord.js/src/managers/ThreadManager.js index fc32c668c7c1..dfa6fe7d6da9 100644 --- a/packages/discord.js/src/managers/ThreadManager.js +++ b/packages/discord.js/src/managers/ThreadManager.js @@ -17,7 +17,7 @@ class ThreadManager extends CachedManager { /** * The channel this Manager belongs to - * @type {NewsChannel|TextChannel|ForumChannel} + * @type {TextChannel|NewsChannel|ForumChannel} */ this.channel = channel; } diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts index 5cd71eca2aad..b1ed70520c3c 100644 --- a/packages/discord.js/typings/index.d.ts +++ b/packages/discord.js/typings/index.d.ts @@ -3674,8 +3674,8 @@ export class StageInstanceManager extends CachedManager { - protected constructor(channel: TextChannel | NewsChannel, iterable?: Iterable); - public channel: TextChannel | NewsChannel; + protected constructor(channel: TextChannel | NewsChannel | ForumChannel, iterable?: Iterable); + public channel: TextChannel | NewsChannel | ForumChannel; public fetch(options: ThreadChannelResolvable, cacheOptions?: BaseFetchOptions): Promise; public fetch(options?: FetchThreadsOptions, cacheOptions?: { cache?: boolean }): Promise; public fetchArchived(options?: FetchArchivedThreadOptions, cache?: boolean): Promise; @@ -3683,10 +3683,12 @@ export class ThreadManager extends CachedManager extends ThreadManager { + public channel: TextChannel | NewsChannel; public create(options: GuildTextThreadCreateOptions): Promise; } export class GuildForumThreadManager extends ThreadManager { + public channel: ForumChannel; public create(options: GuildForumThreadCreateOptions): Promise; }