From 424a339240a3892ffe21249e78b9c4b7e319ec2c Mon Sep 17 00:00:00 2001 From: monbrey Date: Sun, 14 Feb 2021 22:20:19 +1100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Antonio Román --- src/managers/GuildMemberManager.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/managers/GuildMemberManager.js b/src/managers/GuildMemberManager.js index c6f5aa61dfb9..08e3169588f4 100644 --- a/src/managers/GuildMemberManager.js +++ b/src/managers/GuildMemberManager.js @@ -269,12 +269,7 @@ class GuildMemberManager extends BaseManager { await this.client.api.guilds(this.guild.id).members(id).delete({ reason }); - if (user instanceof GuildMember) return user; - const _user = this.client.users.cache.get(id); - if (_user) { - return this.resolve(_user) ?? _user; - } - return id; + return this.resolve(user) ?? this.client.users.resolve(user) ?? id; } /** @@ -300,12 +295,7 @@ class GuildMemberManager extends BaseManager { await this.client.api.guilds(this.guild.id).bans[id].put({ data: options }); - if (user instanceof GuildMember) return user; - const _user = this.client.users.resolve(id); - if (_user) { - return this.resolve(_user) ?? _user; - } - return id; + return this.resolve(user) ?? this.client.users.resolve(user) ?? id; } /**