From a9495bd8f014c8021a214b83ffc531a2af5defef Mon Sep 17 00:00:00 2001 From: Sugden <28943913+NotSugden@users.noreply.github.com> Date: Sat, 25 Feb 2023 14:21:53 +0000 Subject: [PATCH] fix(Message): `bulkDeletable` permissions should be retrieved later for DMs (#9146) * fix(Message): permissions check should be done later the getter will error if used on a message originating from a DM * refactor: remove unessercary chaining --- packages/discord.js/src/structures/Message.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/discord.js/src/structures/Message.js b/packages/discord.js/src/structures/Message.js index 9a1df99d7e36..18ac78549faa 100644 --- a/packages/discord.js/src/structures/Message.js +++ b/packages/discord.js/src/structures/Message.js @@ -645,12 +645,11 @@ class Message extends Base { * channel.bulkDelete(messages.filter(message => message.bulkDeletable)); */ get bulkDeletable() { - const permissions = this.channel?.permissionsFor(this.client.user); return ( (this.inGuild() && Date.now() - this.createdTimestamp < MaxBulkDeletableMessageAge && this.deletable && - permissions?.has(PermissionFlagsBits.ManageMessages, false)) ?? + this.channel?.permissionsFor(this.client.user).has(PermissionFlagsBits.ManageMessages, false)) ?? false ); }