From ba31203a0ad96e0a00f8312c397889351e4c5cfd Mon Sep 17 00:00:00 2001 From: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Date: Sun, 20 Feb 2022 07:43:27 -0500 Subject: [PATCH] refactor: make `data` public in builders (#7486) --- packages/builders/src/components/ActionRow.ts | 3 +++ packages/builders/src/components/Component.ts | 2 +- .../builders/src/components/selectMenu/UnsafeSelectMenu.ts | 3 +++ packages/builders/src/messages/embed/UnsafeEmbed.ts | 2 +- 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/builders/src/components/ActionRow.ts b/packages/builders/src/components/ActionRow.ts index 070461e56cb9..4508d0bc7787 100644 --- a/packages/builders/src/components/ActionRow.ts +++ b/packages/builders/src/components/ActionRow.ts @@ -15,6 +15,9 @@ export type ActionRowComponent = ButtonComponent | SelectMenuComponent; export class ActionRow extends Component< Omit> & { type: ComponentType.ActionRow }, 'components'> > { + /** + * The components within this action row + */ public readonly components: T[]; public constructor({ components, ...data }: Partial> = {}) { diff --git a/packages/builders/src/components/Component.ts b/packages/builders/src/components/Component.ts index b759b5cb2958..15e866f8abde 100644 --- a/packages/builders/src/components/Component.ts +++ b/packages/builders/src/components/Component.ts @@ -19,7 +19,7 @@ export abstract class Component< /** * The API data associated with this component */ - protected readonly data: DataType; + public readonly data: DataType; public abstract toJSON(): APIMessageComponent; diff --git a/packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts b/packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts index 9edc953204ee..386f970f1758 100644 --- a/packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts +++ b/packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts @@ -9,6 +9,9 @@ import isEqual from 'fast-deep-equal'; export class UnsafeSelectMenuComponent extends Component< Partial> & { type: ComponentType.SelectMenu } > { + /** + * The options within this select menu + */ public readonly options: UnsafeSelectMenuOption[]; public constructor(data?: Partial) { diff --git a/packages/builders/src/messages/embed/UnsafeEmbed.ts b/packages/builders/src/messages/embed/UnsafeEmbed.ts index 3e1301709fb3..3d7ce09e4c4b 100644 --- a/packages/builders/src/messages/embed/UnsafeEmbed.ts +++ b/packages/builders/src/messages/embed/UnsafeEmbed.ts @@ -41,7 +41,7 @@ export interface EmbedImageData extends Omit { * Represents a non-validated embed in a message (image/video preview, rich embed, etc.) */ export class UnsafeEmbed implements Equatable { - protected data: APIEmbed; + public readonly data: APIEmbed; public constructor(data: APIEmbed = {}) { this.data = { ...data };