From f70df910ed12e397066d0bdb27343af21ead4d92 Mon Sep 17 00:00:00 2001 From: Almeida Date: Fri, 17 Feb 2023 19:40:10 +0000 Subject: [PATCH] refactor(BitField): reverse iterator/toArray responsibilities (#9118) refactor(BitField): reverse iterator/toArray responsabilities --- packages/discord.js/src/util/BitField.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/discord.js/src/util/BitField.js b/packages/discord.js/src/util/BitField.js index 786b2ea750e9..76e7aefb70ae 100644 --- a/packages/discord.js/src/util/BitField.js +++ b/packages/discord.js/src/util/BitField.js @@ -127,7 +127,7 @@ class BitField { * @returns {string[]} */ toArray(...hasParams) { - return Object.keys(this.constructor.Flags).filter(bit => this.has(bit, ...hasParams)); + return [...this[Symbol.iterator](...hasParams)]; } toJSON() { @@ -138,8 +138,10 @@ class BitField { return this.bitfield; } - *[Symbol.iterator]() { - yield* this.toArray(); + *[Symbol.iterator](...hasParams) { + for (const bitName of Object.keys(this.constructor.Flags)) { + if (this.has(bitName, ...hasParams)) yield bitName; + } } /**