src: Fix up WebSocketShard errors #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amishshah
requested changes
Jan 19, 2020
amishshah
approved these changes
Jan 20, 2020
|
Just leaving my feedback on this PR: Been running this for 2 days now and it seems to be stable enough |
|
I didn't saw that i received a mail for this, sorry.
I added your package, and it work perfectly.
It is fixed on the main discordjs repo ? I'm using TypeScript and typings
are not the same for this repo i guess, it gaves me a lot of errors for
types, but still work.
Thanks anyway.
Le mar. 21 janv. 2020 à 02:31, Saya <notifications@github.com> a écrit :
… Just leaving my feedback on this PR: Been running this for 2 days now and
it seems to be stable enough
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3722?email_source=notifications&email_token=ALMM5RM2NNXXDCINUIHSNB3Q6ZF7ZA5CNFSM4KI2PFU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJOGNGY#issuecomment-576480923>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMM5RJT3RGB44SQ2W24MA3Q6ZF7ZANCNFSM4KI2PFUQ>
.
|
If the WS was not connected when the HELLO timeout passes (CONNECTING, etc), the shard would get stuck due to never rejecting the WebSocketShard#connect Promise with the DESTROYED event
Lewdcario
approved these changes
Jan 31, 2020
SpaceEEC
approved these changes
Feb 2, 2020
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
* src: Fix up WebSocketShard errors * typings: Forgot to update * src: Forgot debug variable * src: Fix issue Bella found If the WS was not connected when the HELLO timeout passes (CONNECTING, etc), the shard would get stuck due to never rejecting the WebSocketShard#connect Promise with the DESTROYED event
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
This reverts commit a1638e0.
BannerBomb
added a commit
to BannerBomb/discord.js
that referenced
this pull request
Feb 8, 2021
I just changed an incorrect key name that was introduced in Pull Request discordjs#3722. When destroying the websocket from the WebSocketShard#_send method it's using `close` as the key name instead of `closeCode`
iCrawl
pushed a commit
that referenced
this pull request
Feb 10, 2021
I just changed an incorrect key name that was introduced in Pull Request #3722. When destroying the websocket from the WebSocketShard#_send method it's using `close` as the key name instead of `closeCode`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
In theory, this change should fix #3706 and should fix #3641! @xKesvaL, @NotSugden and @BannerBomb, please try this PR (since you guys reported the issue)
For anyone else reading this, if you've encountered any of the listed issues, please install this PR and reply here if it works or not!
How to install?
npm i vladfrangu/discOwOd.js#fix-internal-sharding-againoryarn add vladfrangu/discOwOd.js#fix-internal-sharding-againChangelog
The only notable thing is that
WebSocketShard#destroynow takes an object of options and adds a few more options.Status
Semantic versioning classification: