Remove disableMentions #4836
Merged
Remove disableMentions #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Dec 8, 2020
kyranet
approved these changes
Dec 8, 2020
vladfrangu
approved these changes
Dec 8, 2020
SpaceEEC
approved these changes
Dec 10, 2020
|
@advaith1 can you rebase/fix this merge conflict |
advaith1
force-pushed
the
remove-disableMentions
branch
from
0416305
to
7cc8992
Compare
vladfrangu
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
With Discord's
allowed_mentionsfeature, discord.js's hackydisableMentionsfeature is no longer needed.Obviously, this is a very breaking change and should not be merged until v13.
Status
Semantic versioning classification: