Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildMemberManager): extend API coverage #4872

Merged
merged 19 commits into from May 11, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Oct 1, 2020

API Coverage part 2: Electric Boogaloo

Refer to #4869 (nice) for the logic behind these changes

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

src/managers/GuildMemberManager.js Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/structures/GuildMember.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
@iCrawl iCrawl dismissed stale reviews from SpaceEEC and vladfrangu May 6, 2021 04:53

stale

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the other way for GuildMemberManager#kick, currently it's inconsistent.

Otherwise LGTM.

src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
src/managers/GuildMemberManager.js Outdated Show resolved Hide resolved
monbrey and others added 2 commits May 10, 2021 21:22
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@vladfrangu vladfrangu requested a review from SpaceEEC May 10, 2021 13:10
@iCrawl iCrawl merged commit 2e2464b into discordjs:master May 11, 2021
@monbrey monbrey deleted the gmm-api-coverage branch May 29, 2021 01:25
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants