fix(RoleManager): fix ID return value, change return type to collection #4935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
When using
RoleManager#fetch
with a single ID, it tries to get the role fromthis.cache
, however that won't work whencache
is set tofalse
and it will returnnull
even when the role was fetched correctly. This has ben fixed by getting the role from the collection instead.Unlike any other manager, fetching without passing an ID returns the manager instead of the fetched collection, this has been changed for consistency.
Status
Semantic versioning classification: