Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChannelManager): Avoid crash in remove method with uncached channel #4937

Merged
merged 3 commits into from Dec 12, 2020
Merged

fix(ChannelManager): Avoid crash in remove method with uncached channel #4937

merged 3 commits into from Dec 12, 2020

Conversation

AwesomeStickz
Copy link
Contributor

@AwesomeStickz AwesomeStickz commented Oct 25, 2020 •
edited

Please describe the changes this PR makes and why it should be merged:
When the bot leaves a guild, actions/GuildDelete calls ChannelManager.remove from a list of channels which removes the channel from the cache. When it comes to a channel that is not in the cache, it crashes the process. This PR fixes that issue

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Extroonie
Extroonie approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@Extroonie Extroonie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #5067 has been merged, you can safely make use of optional chaining.

src/managers/ChannelManager.js Outdated Show resolved Hide resolved
AwesomeStickz and others added 2 commits December 10, 2020 21:47
@AwesomeStickz
Merge pull request #1 from discordjs/master
5a11d56 
Pull changes
@AwesomeStickz
Use optional chaining
bc54d39 
Co-authored-by: Ishmaam Khan <ishmaamk@gmail.com>
@iCrawl iCrawl merged commit 12c909e into discordjs:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Extroonie Extroonie Extroonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AwesomeStickz @vladfrangu @iCrawl @kyranet @SpaceEEC @Extroonie