Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildChannelManager): add 'fetch' method #4966

Merged
merged 13 commits into from Jun 9, 2021
Merged

feat(GuildChannelManager): add 'fetch' method #4966

merged 13 commits into from Jun 9, 2021

Conversation

Extroonie
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR implements API support for the GET guild-channels endpoint.
Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

papaia
papaia reviewed Nov 1, 2020
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
NotSugden
NotSugden suggested changes Nov 5, 2020
View reviewed changes
src/managers/GuildChannelManager.js Outdated Show resolved Hide resolved
src/managers/GuildChannelManager.js Outdated Show resolved Hide resolved
Ishmaam Khan and others added 3 commits November 6, 2020 14:38
@NotSugden
GuildChannelManager#fetch: fix return type
33960b1 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
GuildChannelManager#fetch: fix incorrect jsdoc
9edb4d6
@NotSugden
GuildChannelManager#fetch: properly cache the channel(s)
e3df0cf 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@Awoocado
ChannelManager#add: pass correct parameters
e63b2b9 
Co-authored-by: Avocado <43632131+Awoocado@users.noreply.github.com>
vladfrangu
vladfrangu approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it's about time we looked into making fetch fuctions take options objects instead of a list of params... Outside the scope of this PR tho 😅

KitsuneDev added a commit to KitsuneDev/discord.js that referenced this pull request Dec 26, 2020
@KitsuneDev
Merge PR discordjs#4966 (GuildChannelManager.fetch)
ddb94e0
@iCrawl iCrawl requested a review from SpaceEEC February 10, 2021 14:54
@iCrawl
Copy link
Member

iCrawl commented Apr 30, 2021

This needs a rebase.

@Extroonie Extroonie changed the title feat(GuildChannelManager): implement GuildChannelManager#fetch feat(GuildChannelManager): add 'fetch' method May 6, 2021
@Extroonie
Copy link
Contributor Author

@iCrawl done

@iCrawl
Copy link
Member

iCrawl commented May 27, 2021

This needs another rebase. @Extroonie

@Extroonie
Copy link
Contributor Author

@iCrawl done x2

@iCrawl iCrawl merged commit e798fb7 into discordjs:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monbrey monbrey monbrey left review comments

@tipakA tipakA tipakA left review comments

@papaia papaia papaia left review comments

@Awoocado Awoocado Awoocado left review comments

@NotSugden NotSugden NotSugden requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Extroonie @iCrawl @monbrey @vladfrangu @kyranet @SpaceEEC @NotSugden @tipakA @papaia @Awoocado