Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ClientPresence): add presence to ClientPresence from ClientOptions #5041

Merged
merged 1 commit into from Dec 13, 2020
Merged

fix(ClientPresence): add presence to ClientPresence from ClientOptions #5041

merged 1 commit into from Dec 13, 2020

Conversation

Mirdukkk
Copy link
Contributor

@Mirdukkk Mirdukkk commented Nov 24, 2020

Please describe the changes this PR makes and why it should be merged:
this PR adds data about the client's presence to the ClientPresence class from the options that were passed in the client constructor. without this PR, the client cannot display its status or activity in any way, because by default, ClientPresence is changed only using the setStatus, setActivity, and setPresence methods. so if these methods are not used, the ClientPresence class always contains only standard values, although in fact the values may differ from those displayed in the Discord.
this PR also fixes an issue where the setStatus and setActivity methods overwritten values for each other. that is, if I set the idle status to the client via setStatus, and then use setActivity to set the activity, the idle status will simply disappear. similarly, in the opposite direction.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Mirdukkk
Copy link
Contributor Author

Mirdukkk commented Dec 3, 2020

hey guys, review my PR please

@iCrawl iCrawl merged commit 9c7fe34 into discordjs:master Dec 13, 2020
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants