Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageReaction): set MessageReaction#me in patch method #5047

Merged
merged 1 commit into from Nov 25, 2020

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Nov 25, 2020

Fixes #5046 by setting MessageReaction#me in MessageReaction#_patch ensuring it gets updated when fetching partials.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 6b322f4 into discordjs:master Nov 25, 2020
@monbrey monbrey deleted the patch-5046 branch November 25, 2020 22:56
@ArrowM
Copy link

ArrowM commented Nov 25, 2020

Thanks buddy :)

@ArrowM
Copy link

ArrowM commented Nov 26, 2020

I just updated to 12.5.1. I think your fix for this reversed the issue - but did not fix it. Now reaction.me is the correct value the first time the event is triggered, but returns false on every subsequent trigger.

@monbrey
Copy link
Member Author

monbrey commented Nov 26, 2020

Sounds like something I'd cause 😁 will look into it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect reaction.me value on first messageReactionAdd event trigger
3 participants